Feedback: slider handle shifting.#357
Draft
Aadil127 wants to merge 2 commits into
Draft
Conversation
Author
Currently it also stops breakpoints from going outside of widget bounds. |
Author
|
I have just seen that in the upstream iced they are only using width for rectangle handle shape and height of handle is same as widget's height. Do i go with that approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
slider.mp4
Bottom 3 sliders are showing bounds for widget, rail and handle.
This adds handle bounds that can be configured while creating slider widget.
To prevent issues for slider widget used in many cosmic application i have set default bounds for handle as defined in theme for slider. ( libcosmic/src/theme/style/iced.rs:755 )
Color picker widget's slider needs to update as it has custom style for slider handle
(without changes slider rail width will be slightly smaller)
Currently nothing is overflowing outside of widget layout.
Need feed back on this approach.