Conversation
jacobgkau
left a comment
There was a problem hiding this comment.
When running through this for the first time in a virtual machine, I saw the first upgrade dialog open with a lot of empty space at the bottom:
Let's also try to better match the text to what's shown in the Figma file linked in #379:
In particular, the first line shouldn't be there, and the paragraph doesn't need to be a bullet point. Are we able to have hyperlinks in this dialog?
The second dialog also looks identical to the first at this point, where they should be different dialogs per the mockup.
|
Maria approved changing the new sublabel to I think we should fix #370 and #371 before releasing this, since they're both low-hanging fruit with logically easy solutions that several people were hit with doing early upgrades. I've got a fix for the latter in progress at #382. |
|
Bold is fine as is. The line break would help since there is an icon on the left. I don't know if we can make the dialog a bit narrower but that might help too. |










Currently testing. It would be ideal to merge this as
master_jammyand then allowmasterto target >=24.04. Then we can drop the GTK library entirely on 24.04 and make changes that are required by pop-upgrade integrations into cosmic-settings.