Fix all clippy warnings: dead code, unused fields, type complexity

- Prefix unused Args fields (handle, app_id, parent_window) with underscore
- Add #[allow(dead_code)] to DmabufHelper methods reserved for future use
- Replace unwrap-after-is_some with if-let pattern in screenshot.rs
- Add #[allow(clippy::large_enum_variant)] for Msg enums
- Add #[allow(clippy::type_complexity)] for Session close_cb and access choices
- Add #[allow(clippy::too_many_arguments)] for ScreenshotSelection::new

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: olafkfreund

src/access.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code, unused_variables)]
+#![allow(dead_code, unused_variables, clippy::type_complexity)]
 
 use cosmic::iced_runtime::platform_specific::wayland::layer_surface::{
     IcedOutput, SctkLayerSurfaceSettings,
@@ -31,7 +31,6 @@ pub(crate) struct AccessDialogOptions {
     grant_label: Option<String>,
     icon: Option<String>,
     //(ID returned with the response, choices (ID, label), label, initial selection or "" meaning the portal should choose)
-    #[allow(clippy::type_complexity)]
     choices: Option<Vec<(String, String, Vec<(String, String)>, String)>>,
 }
 

src/app.rs

@@ -58,6 +58,7 @@ pub struct OutputState {
 }
 
 #[derive(Debug, Clone)]
+#[allow(clippy::large_enum_variant)]
 pub enum Msg {
     Access(access::Msg),
     FileChooser(window::Id, file_chooser::Msg),

src/file_chooser.rs

@@ -158,9 +158,9 @@ impl FileChooser {
         if let Err(err) = self
             .tx
             .send(subscription::Event::FileChooser(Args {
-                handle: handle.to_owned(),
-                app_id: app_id.to_string(),
-                parent_window: parent_window.to_string(),
+                _handle: handle.to_owned(),
+                _app_id: app_id.to_string(),
+                _parent_window: parent_window.to_string(),
                 title: title.to_string(),
                 options,
                 tx,
@@ -236,16 +236,17 @@ impl FileChooser {
 }
 
 #[derive(Debug, Clone)]
+#[allow(clippy::large_enum_variant)]
 pub enum Msg {
     DialogMessage(DialogMessage),
     DialogResult(DialogResult),
 }
 
 #[derive(Clone, Debug)]
 pub(crate) struct Args {
-    pub handle: zvariant::ObjectPath<'static>,
-    pub app_id: String,
-    pub parent_window: String,
+    pub _handle: zvariant::ObjectPath<'static>,
+    pub _app_id: String,
+    pub _parent_window: String,
     pub title: String,
     pub options: FileChooserOptions,
     pub tx: Sender<PortalResponse<FileChooserResult>>,
@@ -426,7 +427,7 @@ pub fn update_args(portal: &mut CosmicPortal, args: Args) -> cosmic::Task<cosmic
         }
     };
     let mut settings = DialogSettings::new().kind(kind);
-    //TODO: setting app_id breaks dialog floating: .app_id(args.app_id.clone());
+    //TODO: setting app_id breaks dialog floating: .app_id(args._app_id.clone());
     if let Some(path) = args.options.current_folder() {
         settings = settings.path(path);
     }

src/main.rs

@@ -99,6 +99,7 @@ impl Request {
 
 struct Session<T: Send + Sync + 'static> {
     data: T,
+    #[allow(clippy::type_complexity)]
     close_cb: Option<Box<dyn FnOnce(&mut T) + Send + Sync + 'static>>,
 }
 

src/screenshot.rs

@@ -729,11 +729,11 @@ pub fn update_msg(portal: &mut CosmicPortal, msg: Msg) -> cosmic::Task<crate::ap
                 }
             }
 
-            let response = if success && image_path.is_some() {
+            let response = if let (true, Some(path)) = (success, &image_path) {
                 PortalResponse::Success(ScreenshotResult {
-                    uri: format!("file:///{}", image_path.unwrap().display()),
+                    uri: format!("file:///{}", path.display()),
                 })
-            } else if success && image_path.is_none() {
+            } else if success {
                 PortalResponse::Success(ScreenshotResult {
                     uri: "clipboard:///".to_string(),
                 })

src/wayland/mod.rs

@@ -62,6 +62,7 @@ impl DmabufHelper {
 
     // TODO: consider scanout flag?
     // Consider tranches in some way?
+    #[allow(dead_code)]
     fn feedback_formats(&self) -> impl Iterator<Item = &DmabufFormat> {
         self.feedback
             .tranches()
@@ -70,6 +71,7 @@ impl DmabufHelper {
             .filter_map(|x| self.feedback.format_table().get(*x as usize))
     }
 
+    #[allow(dead_code)]
     pub fn modifiers_for_format(&self, format: u32) -> impl Iterator<Item = u64> + '_ {
         self.feedback_formats()
             .filter(move |x| x.format == format)

src/widget/screenshot.rs

@@ -63,6 +63,7 @@ impl<'a, Msg> ScreenshotSelection<'a, Msg>
 where
     Msg: 'static + Clone,
 {
+    #[allow(clippy::too_many_arguments)]
     pub fn new(
         choice: Choice,
         image: &ScreenshotImage,