Skip to content

chore: Migrate from Makefile to justfile#254

Open
FreddyFunk wants to merge 1 commit intopop-os:masterfrom
FreddyFunk:chore/migrate-to-justfile
Open

chore: Migrate from Makefile to justfile#254
FreddyFunk wants to merge 1 commit intopop-os:masterfrom
FreddyFunk:chore/migrate-to-justfile

Conversation

@FreddyFunk
Copy link

same story like my other pull requests for migrations to just.

@jackpot51 jackpot51 requested review from a team January 16, 2026 17:45
@jacobgkau jacobgkau force-pushed the chore/migrate-to-justfile branch from bfc423b to 91c8877 Compare February 11, 2026 21:29
Copy link
Member

@jacobgkau jacobgkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This builds fine locally, but failed to build on the build server.

Build server output:
   Compiling xdg-desktop-portal-cosmic v0.1.0 (/<<PKGBUILDDIR>>)
warning: fields `handle`, `app_id`, and `parent_window` are never read
   --> src/file_chooser.rs:246:9
    |
245 | pub(crate) struct Args {
    |                   ---- fields in this struct
246 |     pub handle: zvariant::ObjectPath<'static>,
    |         ^^^^^^
247 |     pub app_id: String,
    |         ^^^^^^
248 |     pub parent_window: String,
    |         ^^^^^^^^^^^^^
    |
    = note: `Args` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
    = note: `#[warn(dead_code)]` on by default

warning: methods `feedback_formats` and `modifiers_for_format` are never used
  --> src/wayland/mod.rs:65:8
   |
58 | impl DmabufHelper {
   | ----------------- methods in this implementation
...
65 |     fn feedback_formats(&self) -> impl Iterator<Item = &DmabufFormat> {
   |        ^^^^^^^^^^^^^^^^
...
73 |     pub fn modifiers_for_format(&self, format: u32) -> impl Iterator<Item = u64> + '_ {
   |            ^^^^^^^^^^^^^^^^^^^^

E: ABORT: Received TERM signal (requesting cleanup and shutdown)
E: Caught signal ‘Terminated’: terminating immediately
error: Recipe `build-debug` was terminated on line 38 by signal 15
make[1]: *** [debian/rules:20: override_dh_auto_build] Error 143
make: *** [debian/rules:8: build] Terminated
--------------------------------------------------------------------------------
Build finished at 2026-02-11T21:47:14Z

Finished
--------

Not sure what's causing this, as the warnings don't look like they should necessarily cause a build failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants