Preliminary support for shelves #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no way yet to know which slot is being clicked so it's checks both deposit and withdraw for now. It's also a little weird in that you can have connected shelves of different owners and technically modify ones you cannot access by swapping with the shelf you can access. Not sure how to handle this yet. Shelves are locked by default.
|
Looks good to me so far, definitely would like some API for this before merging though, if possible |
pop4959
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no way yet to know which slot is being clicked so it's checks both deposit and withdraw for now (see PaperMC/Paper#12563). It's also a little weird in that you can have connected shelves of different owners and technically modify ones you cannot access by swapping with the shelf you can access. Not sure how to handle this yet.
Shelves are locked by default.