-
Notifications
You must be signed in to change notification settings - Fork 18
Fix border wrapping on folia #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some initial comments & requests:
Aside from that, the changes here look generally good to me at a glance. Thanks for cooking this draft up. |
| playerData.setLastLocation(location); | ||
| } else if (!player.hasPermission("chunkyborder.bypass.move") && !playerData.isBypassing()) { | ||
| final Location redirect; | ||
| } else if (!playerData.isBypassing() && !player.hasPermission("chunkyborder.bypass.move")) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch here
|
Thanks for addressing my comments, this is more in-line with what I was expecting for a refactor in this part of the code. Pending the merging of pop4959/Chunky#424 this looks good. |
9f3425e to
c6e3725
Compare
This PR fixes wrapping on folia by using getElevation non-blockingly, and as a free bonus, prevents doing a sync chunk load on paper servers.