Skip to content

Conversation

@senseiwells
Copy link
Contributor

Fixes an issue that ServerReplay has with BorderPayloads causing NullPointerExceptions, since BorderPayloads were never intended to be read in then written back out. This PR fixes this by removing the 2 possible states the payload can be in and merging them into one.

The user that reported the bug confirmed that this fixes the issue.

Copy link
Owner

@pop4959 pop4959 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nitpick but otherwise fine! Thanks for the PR!

@pop4959 pop4959 merged commit 139b774 into pop4959:master Mar 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants