Improve performance of protection checks under Paper

[Phoenix616]

Improve performance of protection checks under Paper by not creating a snapshot for each block.

Previously this could cause lag spikes if something (like hoppers or other plugins which move items) would check lots of blocks for protections at the same time. I tried to check the logic which uses those objects/methods whether they actually would require a snapshot and I couldn't find any.

[pop4959]

Good find, seems like a reasonable change - I don't think we use the snapshots anywhere. Do you know if this also works on Spigot, or is it Paper only?

[Phoenix616]

This is a Paper-only api addition.

[pop4959]

Thanks that's kind of what I thought, but I didn't have time to check. There's still a bit to figure out b/w the Spigot and Paper implementation going forwards but now that we have them essentially split after hard fork this should make sense to do. In the past it was mostly that no one bothered to make it cross compatible.