Added network plug to snapcraft.yaml

[mahazza]

Solves issue
#16

[popey]

Thanks @mahazza !
Would it also need network-bind - especially if you're running a game server for example?

[mahazza]

@popey I decided not to add it, only because i couldn't think of a great reason. There probably are good reasons though! The dosbox-x snap has "network-bind" in its plugs.

"network" lets you bind to ports >= 1024 and worked fine for me with the ipx example in #16. You do need to specify a high enough port there though.

"network-bind" allows binding to well known/system ports below 1024, like 80, 443, 22, etc.

One not very good example I can think of is classic DOOM which uses 666 for its multiplayer. There is without a doubt a lot of software that used < 1024 ports that i don't know about.

So, maybe I talked myself into adding it. What do you reckon?

[popey]

Thanks for being thoughtful about it.

I dug back through the history of the dosbox-x snap. I originally created it back in 2018. Looks like it had network and network-bind from the start. So yes, I would add both. I can see no reason not to.