Skip to content

Added aggregate percentage display based on user preference#245

Open
siddiqus wants to merge 108 commits intopophealth:masterfrom
siddiqus:master
Open

Added aggregate percentage display based on user preference#245
siddiqus wants to merge 108 commits intopophealth:masterfrom
siddiqus:master

Conversation

@siddiqus
Copy link

selecting measure calculates the percentage for the user and for all the patients in the database (aggregate). User can choose preference for displaying the aggregate measure on the dashboard.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be an unless

@eedrummer
Copy link
Member

Please remove tab characters from the code.

I understand what you are trying to do here with the aggregate percentage. I'm not sure this is the best way to go about it.

  • This code looks for a quality report where there is no provider. The code should really look for the quality report of the root provider
  • This code essentially duplicates part of the root provider quality report on child quality reports if they are viewed. I don't see why this would be necessary.

My suggestion would be to just ask for the quality report of the root provider to display as the aggregate.

Also, this throws off the alignment of the patients button on CV measures.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid inline styles, and also please avoid !important rules if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants