-
Notifications
You must be signed in to change notification settings - Fork 94
Add almond species and demographic model #1729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add almond species and demographic model #1729
Conversation
|
Issue for this PR is at #1730 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1729 +/- ##
==========================================
- Coverage 99.81% 99.55% -0.27%
==========================================
Files 142 146 +4
Lines 4873 4903 +30
Branches 472 473 +1
==========================================
+ Hits 4864 4881 +17
- Misses 6 19 +13
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Gregor Gorjanc <[email protected]>
Co-authored-by: Gregor Gorjanc <[email protected]>
Co-authored-by: Gregor Gorjanc <[email protected]>
Co-authored-by: Gregor Gorjanc <[email protected]>
|
@jorgemasgomez good job on squashing the above points. Let me know when you are done with all the points and then we will QC this via the test file. |
|
In relation to the genome information, the v3 assembly of the ‘Texas’ cultivar is the most recent one. It is a phased genome assembly, therefore the reported genome length corresponds to the average length of both haplotypes. |
|
Regarding the demographic model, data points for population size over time were obtained by digitizing the line plot shown in Figure S8a. |
|
@jorgemasgomez these changes look all very good and correct (I have cross-checked everything on my end). I left few minor editing nitpicks for you to accept;) @petrelharp how should we handle this PR - it has:
I have not yet QCed the demographic model. I propose I QC this part as well and we merge in this PR as all 4 things in on (species addition & QC and demographic model & QC). Or should we split this out into separate PRs? |
Co-authored-by: Gregor Gorjanc <[email protected]>
Co-authored-by: Gregor Gorjanc <[email protected]>
Co-authored-by: Gregor Gorjanc <[email protected]>
|
@gregorgorjanc I have accepted and addressed the nitpicks! :) |
No description provided.