fix: remove catch from handler in transaction#444
Open
charsleysa wants to merge 3 commits intoporsager:masterfrom
Open
fix: remove catch from handler in transaction#444charsleysa wants to merge 3 commits intoporsager:masterfrom
charsleysa wants to merge 3 commits intoporsager:masterfrom
Conversation
|
@porsager Are there any plans to merge this? |
|
@charsleysa why does this PR have the docker file changes? |
Author
|
@mattbishop those were config files added for working in VSCode isolated workspaces. I can remove them if it's blocking the PR. |
|
Any thoughts on when this can be merged? |
porsager
force-pushed
the
master
branch
2 times, most recently
from
4fd011e to
a92f470
Compare
porsager
force-pushed
the
master
branch
2 times, most recently
from
4a0fe34 to
3a43815
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where catching an error inside a transaction and running custom error logic doesn't work due to a hidden catch and rethrow occurring.