Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the install.sh installer by extracting logic into functions and adjusts the --download-only flow so it runs before root checks and pre-flight validation, aligning with the goal of preparing offline bundles from non-root developer machines (KS-35).
Changes:
- Moves
--download-onlyinto an early “no-root” path and factors downloading intodownload_bundle(). - Refactors installer responsibilities into additional bash/sh functions (download/install/service creation).
- Updates installation docs to clarify
--download-onlydoesn’t require root and removessudofrom the examples.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
install.sh |
Reorganizes the installer into functions; adds early download-only entry path and helper functions for downloading/installing. |
docs/installation/flags.md |
Updates --download-only documentation and usage examples to run without root. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
Dropping my 2c on this, but usually when I see a bash script reaching > 1000 LOC I start asking myself questions 🕵 |
add a fix for intall script terminating itself on offline install mode attempt to fix self terminate and updating informational message adding fixes adding fixes
yajith
force-pushed
the
fix/install-script-issues
branch
from
1aa4263 to
ff4192c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: KS-35