Conversation
…nvironment doesn't work yet because of crack-egg and pan-fry actions
…nments for crack and fry
…dicates for cracking the egg and pan frying. 3 new environments, two for each action and one with both actions
chalo2000
left a comment
There was a problem hiding this comment.
This PR is almost ready to go! We just need to remove the dangling .DS_Store (take a look at Files changed, they were committed before it was added to the .gitignore and more importantly we need to make the pan a container that can be picked up. Speak to @lsuyean about this.
| if self.is_goal_reached(): | ||
| return self, True | ||
|
|
||
| # TODO: DEBUGGING |
There was a problem hiding this comment.
remove comment if TODO already resolved, otherwise put the TODO in this format
# TODO(your_username): This is an error message)
and create a Git issue associated with it that should be mentioned in the PR
chalo2000
left a comment
There was a problem hiding this comment.
Almost good to merge in, just need to fix the rendering so the egg looks like it is actually in the container.
|
@ian-urqu I looked through the PR, what's the progress in fixing the rendering on the egg? Do let me know if there are any issues with this. Also, I noticed a bug where the egg continues to fry even though it is not in the pan. This is probably because the conditional effect is only dependent on the pan being at the stove, but not the egg. Leave the condition that the pan should be on the stove, but also add the condition that the egg must be atop the pan. |
| POTATO = "potato" | ||
| EGG_YOLK = "egg_yolk" | ||
| EGG = "egg" | ||
| PAN = "pan" |
Added new fried egg task with actions for cracking an egg and pan frying it.
Overview
In this new PR, I implement a new fried egg task with new environments, actions, items, and inputs.
Changes Made
Test Coverage
I created 3 new environments to test the two new actions. Two environments were for the two separate actions of cracking and frying, and the third was a combination of those two, so first crack the egg then fry it.
Screenshots
Crack and Fry Egg
Screen.Recording.2024-11-01.at.6.30.40.PM.mov