Add device subdirectory support for APPS layout in firmware - #3126
Draft
jLynx wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR optimizes the release workflow by consolidating device-specific SD card assets into a single "universal" ZIP file. It also introduces a structured directory layout for external applications (
.ppma/.ppmp), ensuring that different hardware targets (HackRF, PortaRF, HackRF Pro) load the correct binaries from dedicated subdirectories on the SD card.Key Changes
1. Workflow & Release Optimization
device_subdirto the build matrix to facilitate organized file placement during the build process.2. Firmware & App Directory Logic
APPS/<device_subdir>/(e.g.,APPS/hackrf,APPS/portarf, orAPPS/hpro) instead of a flatAPPS/root.init_apps_dir()infile_path.cppto detect the hardware at runtime and point theapps_dirpath to the correct subdirectory.main.cppto initialize these paths immediately after successful hardware initialization.CMakeLists.txtand internal helper scripts (copy_external_apps.sh,fast_flash_pp_and_copy_apps.py) now respect theDEVICE_SUBDIRenvironment variable.3. Build System Improvements
artifact_suffixconsistently across nightly and stable workflows to prevent binary collisions when creating combined archives.Technical Details
/APPS/*.ppma/APPS/<device>/*.ppma/APPSportapack::device_typeImpact
Important
Ensure that existing users are informed to move their custom apps to the new subdirectories or perform a clean install from the new consolidated SD card ZIP to ensure apps remain visible in the UI.