Fix GeoPos DMS edge carry rollback at clamped degree limits - #3284
Merged
Conversation
Co-authored-by: gullradriel <3157857+gullradriel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code as per review comment for pull request 3283
Fix GeoPos DMS edge carry rollback at clamped degree limits
Aug 7, 2026
Member
|
@copilot confirm if the conditions are there that going up/down seconds can wrap/increment/decrement minutes and hours too |
Contributor
Author
Yes — the current logic keeps normal carry/borrow from seconds → minutes → degrees in both directions, and only blocks the rollover when the degree limit is already clamped. Confirmed cases:
|
gullradriel
marked this pull request as ready for review
August 7, 2026 20:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief description of what you did
This addresses the review comment on
ui_geomap.cppwhere DMS wrap-carry could cause discontinuities at clamped latitude/longitude bounds (e.g.,90°59'59"incrementing to90°00'00").The change keeps normal digit carry behavior, while rolling back wrapped minutes/seconds when the carry target is clamped and unchanged, so users can still fully increment/decrement digits across limits and around zero transitions.
Issue scope
GeoPoswere updated (lat/lonseconds→minutes and minutes→degrees).Behavior change
59on increment,0on decrement).Result
Proof that your changes work
N/A in this write-up.
🖥️ Proof it compiles
N/A in this write-up.
📱 Proof of testing on a real device
N/A in this write-up.
📡 Proof against a real emitter/receiver (if applicable)
N/A — UI numeric wrap/carry logic change; no RF path modified.
📚 Wiki documentation commitment
Checklist