Remove dead _previous_frequency state from BigFrequency widget - #3294
Merged
Conversation
… paint() guard Co-authored-by: gullradriel <3157857+gullradriel@users.noreply.github.com>
Co-authored-by: gullradriel <3157857+gullradriel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix code based on review comment
Remove dead Aug 18, 2026
_previous_frequency state from BigFrequency widget
gullradriel
reviewed
Aug 18, 2026
gullradriel
reviewed
Aug 18, 2026
gullradriel
marked this pull request as ready for review
August 18, 2026 18:25
gullradriel
enabled auto-merge (squash)
August 18, 2026 18:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BigFrequencyretained a_previous_frequencymember that was no longer used inpaint(), leaving dead state in the class and making the header disagree with the implementation.Brief description of what you did
rf::Frequency _previous_frequency{~0LL}fromBigFrequencyinui_widget.hpp— it was dead state after the paint guard was removed.if (_frequency != _previous_frequency)guard frompaint()—paint()is now unconditional, which is correct since the widget framework gates it.set()to preserve the optimization (skip repaints when frequency hasn't changed) without needing the extra member:This keeps the redraw behavior correct while eliminating the stale member.
Proof that your changes work
Code-only cleanup; no behavioral change to observable output.
🖥️ Proof it compiles
N/A — trusted contributor
📱 Proof of testing on a real device
N/A — no functional change; only removes dead state and restructures the dirty-check.
📡 Proof against a real emitter/receiver (if applicable)
N/A — no RF changes.
📚 Wiki documentation commitment
N/A — internal widget refactor, no user-visible feature change.
Checklist