for app jammer failure fix - #3303
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a shared “fast hopping” safety confirmation dialog to prevent UI lockups when Jammer/Hopper are started with unsafe hop intervals (< 50 ms), and refactors the existing Hopper warning into the shared helper.
Changes:
- Introduces
start_with_fast_hop_warning()helper to gate TX start behind a confirmation modal for hop intervals below 50 ms. - Updates Jammer to use the shared helper (converting its 10 ms hop units to milliseconds for the warning threshold check).
- Replaces Hopper’s inline “0 ms fastest” warning with the shared helper so all < 50 ms intervals are covered.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| firmware/application/external/ui_fast_hop_warning.hpp | Adds shared helper that shows a warning modal and preserves a 50 ms UI-render delay before starting TX. |
| firmware/application/external/jammer/ui_jammer.cpp | Uses the shared helper when starting TX to warn on hop intervals < 50 ms. |
| firmware/application/external/hopper/ui_hopper.cpp | Refactors previous inline warning to the shared helper and expands coverage to all < 50 ms hop intervals. |
Suppressed comments (1)
firmware/application/external/ui_fast_hop_warning.hpp:64
- The trailing
#endifcomment still references the reserved__...__guard name. Update it to match the new non-reserved include guard macro name for clarity and consistency.
#endif /* __UI_FAST_HOP_WARNING_HPP__ */
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
copy hup warn code and change if logic. |
gullradriel
enabled auto-merge (squash)
August 28, 2026 10:24
gullradriel
marked this pull request as draft
August 28, 2026 10:24
auto-merge was automatically disabled
August 28, 2026 10:24
Pull request was converted to draft
gullradriel
marked this pull request as ready for review
August 28, 2026 10:24
Member
|
All comment are solved, you dumb @copilot |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warn Before Fast Hopping
Summary
Add a confirmation dialog before starting Jammer or Hopper with a hopping interval below 50 ms.
Problem
Very short hopping intervals generate retune events faster than the M0 MCU can process them. This can make the UI unresponsive and require a hardware reset.
Hopper already displayed a warning for its fastest hopping mode. Jammer did not have equivalent protection, and Hopper did not warn for every unsafe interval.
Changes