Change current frequency display text to BigFrequency for better visuals in the SignalHunter external app - #3305
Merged
Conversation
Member
|
I didn't read yet but do you mind me asking if the number would been cut when frequency greater than 1GHz? |
Contributor
Author
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the SignalHunter external app’s main screen to use the existing BigFrequency widget for the current frequency readout, improving readability/visuals compared to the prior small Text display.
Changes:
- Replaced the main-view “current frequency”
Textwidget with aBigFrequencywidget inHunterMainView. - Updated view initialization and state update paths (
on_show,focus,set_recording_state,update_frequency) to drive the newBigFrequencydisplay and its style.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| firmware/application/external/signal_hunter/ui_signal_hunter.hpp | Swaps the main frequency readout member from Text to BigFrequency. |
| firmware/application/external/signal_hunter/ui_signal_hunter.cpp | Updates widget registration and frequency/style update logic to use big_display. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Brief description of what you did
I'm changing the current frequency text to be the now fixed BigFrequency for prettier aesthetics.
Proof that your changes work
🖥️ Proof it compiles
📱 Proof of testing on a real device
📡 Proof against a real emitter/receiver (if applicable)
N/A - ui change
📚 Wiki documentation commitment
Checklist