Skip to content

Change current frequency display text to BigFrequency for better visuals in the SignalHunter external app - #3305

Merged
zxkmm merged 1 commit into
portapack-mayhem:nextfrom
GitClo:signal_hunter/big_frequency
Aug 28, 2026
Merged

Change current frequency display text to BigFrequency for better visuals in the SignalHunter external app#3305
zxkmm merged 1 commit into
portapack-mayhem:nextfrom
GitClo:signal_hunter/big_frequency

Conversation

@GitClo

@GitClo GitClo commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Brief description of what you did

I'm changing the current frequency text to be the now fixed BigFrequency for prettier aesthetics.


Proof that your changes work

🖥️ Proof it compiles

...
Space remaining in flash ROM: 29844 bytes ( 2.8 %)

copy /home/d3m0n/developement/mayhem-firmware/firmware/tools/fast_flash_pp_and_copy_apps.py to /home/d3m0n/developement/mayhem-firmware/build/flash.py

WARNING: Compiler version mismatch, please use the official compiler version 9.2.1 when sharing builds! Current compiler version: 9.3.1
[100%] Built target firmware
[100%] Generating portapack-mayhem_OCI.ppfw.tar
APPS/
...
APPS/digitalrain_app.ppmp
APPS/pacman_app.ppmp
FIRMWARE/
FIRMWARE/portapack-mayhem_dev.bin
[100%] Built target ppfw

📱 Proof of testing on a real device

screenshot_mayhem_fh_bf

📡 Proof against a real emitter/receiver (if applicable)

N/A - ui change


📚 Wiki documentation commitment

  • I will (or already) create(d) wiki document for my newly added feature

Checklist

  • Kept changes minimal and limited to necessary files
  • Verified functionality remains intact and code compiles
  • Attached proof that the code compiles successfully (or marked N/A as a trusted contributor)
  • Attached proof of testing on real PortaPack hardware (or marked N/A as a trusted contributor)
  • Attached proof of testing against a real emitter/receiver (if RF-related), or marked N/A with justification
  • I understand that by getting this PR merged, I am implicitly agreeing to create or update the corresponding wiki page (including a main-screen screenshot, description, controls, and limitations)
  • I own all rights to this code (i.e., all code contained in this PR), including compliant usage rights for third-party libraries, and I agree that this code is licensed under the license of this project (GPL-3.0).
  • If any third-party libraries are used, I confirm that their licenses comply with the requirements for contributing to this repository.
  • Reviewed the Contributing Guidelines

@GitClo GitClo changed the title Change current frequency display text to BigFrequency for better visuals Change current frequency display text to BigFrequency for better visuals in the SignalHunter external app Aug 27, 2026
@zxkmm

zxkmm commented Aug 28, 2026

Copy link
Copy Markdown
Member

I didn't read yet but do you mind me asking if the number would been cut when frequency greater than 1GHz?
Cuz from the screenshot it looks like only works for sub 1GHz, but it's not me who wrote that big frequency so there might be some policy to move or tune size after digits reaches?

@GitClo

GitClo commented Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

I didn't read yet but do you mind me asking if the number would been cut when frequency greater than 1GHz? Cuz from the screenshot it looks like only works for sub 1GHz, but it's not me who wrote that big frequency so there might be some policy to move or tune size after digits reaches?

screenshot_mayhem_fh_bf2

Hi, I tried 6ghz and as you can see it fits.

It removes up to 3 leading zeros.
Supports max frequency of 9999.999mhz (7 digits) and it centers based on the number of visible digits.
digit_pos = {(Coord)(screen_width - ((7 * digit_width) + 8) - (i * digit_width)) / 2, ...};

@zxkmm zxkmm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Nice!

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SignalHunter external app’s main screen to use the existing BigFrequency widget for the current frequency readout, improving readability/visuals compared to the prior small Text display.

Changes:

  • Replaced the main-view “current frequency” Text widget with a BigFrequency widget in HunterMainView.
  • Updated view initialization and state update paths (on_show, focus, set_recording_state, update_frequency) to drive the new BigFrequency display and its style.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
firmware/application/external/signal_hunter/ui_signal_hunter.hpp Swaps the main frequency readout member from Text to BigFrequency.
firmware/application/external/signal_hunter/ui_signal_hunter.cpp Updates widget registration and frequency/style update logic to use big_display.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@zxkmm
zxkmm merged commit ca9ca93 into portapack-mayhem:next Aug 28, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants