Skip to content

LSP for Kubernetes manifests #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nlamirault merged 2 commits into from
Nov 6, 2025
Merged

LSP for Kubernetes manifests #6833

nlamirault merged 2 commits into from
Nov 6, 2025

Conversation

@nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Nov 6, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • New Features

    • Added k8s service ingress routing via Cloudflare tunnel.
    • Implemented comprehensive PII/sensitive data redaction for trace processing.
    • Enhanced log collection with improved pod-level filtering and concurrent processing.
    • Integrated Datadog exporter for logs, metrics, and traces pipelines.

  • Configuration Updates

    • Improved data protection mechanisms across telemetry pipelines.
    • Extended collector capabilities for better data filtering and export options.

@nlamirault
feat(cloudflared): add kube api
3156d8b 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault
feat(lsp): update manifests
4294491 
Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault self-assigned this Nov 6, 2025
@nlamirault nlamirault added priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix status/in_progress This issue or PR is being worked on, and has someone assigned area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt labels Nov 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

This PR adds YAML language server schema directives to 50+ dashboard template files across multiple Helm charts for IDE validation and schema support. Additionally, it significantly restructures the OpenTelemetry collector configuration with new filelog receivers for Kubernetes pods, comprehensive PII redaction for traces, trace transformations, and Datadog API exporter routing updates.

Changes

Cohort / File(s) Summary
YAML Language Server Schema Directives
gitops/argocd/charts/ai/k8sgpt/templates/dashboard.yaml, gitops/argocd/charts/database/clickhouse-operator/templates/dashboards.yaml, gitops/argocd/charts/database/cloudnativepg/templates/configmap-dashboards.yaml, gitops/argocd/charts/database/qdrant/templates/dashboards.yaml, gitops/argocd/charts/dora/dora-github/templates/configmap-dashboards.yaml, gitops/argocd/charts/finops/opencost/templates/configmap-dashboards.yaml, gitops/argocd/charts/gateway-api/traefik/templates/configmap-dashboards.yaml, gitops/argocd/charts/gitops/argo-cd/templates/configmap-dashboards.yaml, gitops/argocd/charts/gitops/argo-rollouts/templates/configmap-dashboards.yaml, gitops/argocd/charts/gitops/argo-workflows/templates/configmap-dashboards.yaml, gitops/argocd/charts/ingress-system/ingress-nginx/templates/configmap-dashboards.yaml, gitops/argocd/charts/keptn/keptn/templates/configmap-dashboards.yaml, gitops/argocd/charts/kube-system/cilium/templates/*, gitops/argocd/charts/kube-system/karpenter/templates/configmap-dashboards.yaml, gitops/argocd/charts/kube-system/node-problem-detector/templates/configmap-dashboards.yaml, gitops/argocd/charts/logging/loki/templates/*, gitops/argocd/charts/monitoring/blackbox-exporter/templates/configmap-dashboards.yaml, gitops/argocd/charts/monitoring/gatus/templates/configmap-overview.yaml, gitops/argocd/charts/monitoring/kube-prometheus-stack/templates/*, gitops/argocd/charts/monitoring/mimir/templates/dashboard.yaml, gitops/argocd/charts/monitoring/monitoring-aws/templates/configmap-dashboards.yaml, gitops/argocd/charts/monitoring/snmp-exporter/templates/configmap-dashboards.yaml, gitops/argocd/charts/monitoring/speedtest-exporter/templates/configmap-dashboards.yaml, gitops/argocd/charts/monitoring/unifi-poller/templates/configmap-dashboards.yaml, gitops/argocd/charts/observability/grafana-dashboards/templates/dashboard.yaml, gitops/argocd/charts/observability/grafana-operator/templates/*, gitops/argocd/charts/opentelemetry/beyla/templates/configmap-dashboards.yaml, gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates.old/configmap-dashboards.yaml, gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates/configmap-dashboards.yaml, gitops/argocd/charts/opentelemetry/quickwit/templates/configmap-dashboards.yaml, gitops/argocd/charts/reliability/pyrra/templates/configmap-dashboards.yaml, gitops/argocd/charts/reliability/sloth/templates/configmap-dashboards.yaml, gitops/argocd/charts/secrets/external-secrets/templates/configmap-dashboards.yaml, gitops/argocd/charts/security/falco/templates/dashboard.yaml, gitops/argocd/charts/security/trivy-operator/templates/configmap-dashboards.yaml, gitops/argocd/charts/security/vulnerability-operator/templates/configmap-dashboards.yaml		 Adds yaml-language-server schema directive comments before GrafanaDashboard and related CRD manifests in Helm templates to enable IDE schema validation and IntelliSense. Non-functional metadata additions appearing in one or two locations per file depending on conditional blocks.
OpenTelemetry Collector Configuration
gitops/argocd/charts/opentelemetry/opentelemetry-collector/values.yaml		 Replaces filelog receiver with filelog/k8s_pods for enhanced Kubernetes pod log ingestion; introduces comprehensive PII redaction scheme with blocked key/value patterns, email sanitization, and hash functions; adds transform/standardize_fields and transform/redact_sensitive processors for trace normalization; migrates from otlphttp/datadog to dedicated datadog exporter with API key transport; updates logs and traces pipelines to wire new receivers and processors, enabling Datadog export across multiple pipeline variants (saas/local).
Network Configuration
gitops/argocd/charts/network/cloudflare-tunnel/values-talos-homelab.yaml		 Adds new ingress rule mapping hostname k8s.portefaix.xyz to service https://192.168.0.61:6443 with TLS verification disabled.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~35 minutes

  • Areas requiring extra attention:
    • gitops/argocd/charts/opentelemetry/opentelemetry-collector/values.yaml: Complex receiver/processor/exporter pipeline rewiring with multiple interconnected changes (filelog receiver replacement, PII redaction logic, Datadog exporter routing); requires validation of pipeline chaining and exporter configuration correctness
    • Schema directive lines across 50+ files should be spot-checked for consistency and correct schema URLs, though changes are repetitive and homogeneous

Possibly related PRs

Suggested labels

priority/medium, size/l

Poem

🐰 Dashboards now wear schema hats,
Editors know where schemas are at,
OpenTel logs hop through k8s fields,
PII hides while Datadog yields,
Validation and redaction—quite the feat!

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/yaml-lsp
📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e3dac73 and 4294491.

📒 Files selected for processing (45)
  • gitops/argocd/charts/ai/k8sgpt/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/database/clickhouse-operator/templates/dashboards.yaml (1 hunks)
  • gitops/argocd/charts/database/cloudnativepg/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/database/qdrant/templates/dashboards.yaml (1 hunks)
  • gitops/argocd/charts/dora/dora-github/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/finops/opencost/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/gateway-api/traefik/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/gitops/argo-cd/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/gitops/argo-rollouts/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/gitops/argo-workflows/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/ingress-system/ingress-nginx/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/keptn/keptn/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/kube-system/cilium/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/kube-system/cilium/templates/dashboards.yaml (1 hunks)
  • gitops/argocd/charts/kube-system/karpenter/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/kube-system/node-problem-detector/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/logging/loki/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/logging/loki/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/blackbox-exporter/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/gatus/templates/configmap-overview.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/kube-prometheus-stack/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/kube-prometheus-stack/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/mimir/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/monitoring-aws/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/snmp-exporter/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/speedtest-exporter/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/monitoring/unifi-poller/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/network/cloudflare-tunnel/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/observability/grafana-dashboards/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/observability/grafana-operator/templates/contactpoint.yaml (3 hunks)
  • gitops/argocd/charts/observability/grafana-operator/templates/datasource.yaml (1 hunks)
  • gitops/argocd/charts/observability/grafana-operator/templates/folder.yaml (1 hunks)
  • gitops/argocd/charts/observability/grafana-operator/templates/instance.yaml (1 hunks)
  • gitops/argocd/charts/observability/grafana-operator/templates/notificationpolicy.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/beyla/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates.old/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/opentelemetry/opentelemetry-collector/values.yaml (9 hunks)
  • gitops/argocd/charts/opentelemetry/quickwit/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/reliability/pyrra/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/reliability/sloth/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/secrets/external-secrets/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/security/falco/templates/dashboard.yaml (1 hunks)
  • gitops/argocd/charts/security/trivy-operator/templates/configmap-dashboards.yaml (1 hunks)
  • gitops/argocd/charts/security/vulnerability-operator/templates/configmap-dashboards.yaml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nlamirault nlamirault marked this pull request as ready for review November 6, 2025 08:12
@nlamirault nlamirault merged commit 6dd6e69 into master Nov 6, 2025
21 checks passed
@nlamirault nlamirault deleted the feat/yaml-lsp branch November 6, 2025 08:12
@github-actions github-actions bot added size/l Size L kind/feature Categorizes issue or PR as related to a new feature labels Nov 6, 2025
@dosubot dosubot bot added dependency/argo Dependency Argo priority/medium This issue or PR may be useful, and needs some attention labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nlamirault nlamirault

Labels

area/kubernetes Kubernetes dependency/argo Dependency Argo kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix priority/medium This issue or PR may be useful, and needs some attention size/l Size L status/in_progress This issue or PR is being worked on, and has someone assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nlamirault