Skip to content

Conversation

@nlamirault
Copy link
Collaborator

@nlamirault nlamirault commented Nov 6, 2025

Signed-off-by: Nicolas Lamirault [email protected]

Summary by CodeRabbit

  • New Features

    • Added new Helm chart for kro-apps with support for Kubernetes and AWS deployments, including resource templates and configuration management.
    • Enabled AWS integration capabilities for staging environments.
  • Configuration

    • Updated application deployment namespaces for infrastructure reorganization across multiple environments.
  • Chores

    • Removed license headers from configuration files.

Signed-off-by: Nicolas Lamirault <[email protected]>
@nlamirault nlamirault self-assigned this Nov 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 6, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The PR updates ArgoCD ApplicationSet configurations to change target namespaces from "home" to "krm" for applications, introduces a new Kro-apps Helm chart with application templates and resource graph definitions, and removes license headers from multiple existing chart files.

Changes

Cohort / File(s) Summary
ArgoCD ApplicationSet namespace updates
gitops/argocd/apps/krm/values-aws-staging.yaml, gitops/argocd/apps/krm/values-talos-homelab.yaml
Changed target namespace from "home" to "krm" for applications in ArgoCD generators list.
License header removals
gitops/argocd/charts/krm/ack/Chart.yaml, gitops/argocd/charts/krm/ack/values-talos-homelab.yaml, gitops/argocd/charts/krm/ack/values.yaml, gitops/argocd/charts/krm/kro/Chart.yaml, gitops/argocd/charts/krm/kro/values-talos-homelab.yaml, gitops/argocd/charts/krm/kro/values.yaml
Removed Apache-2.0 and SPDX license header blocks; configuration content remains unchanged.
Kro-apps Helm chart metadata
gitops/argocd/charts/krm/kro-apps/Chart.yaml
Added Helm chart manifest declaring kro-apps application with dependency on kro-factory from OCI registry (v0.1.0).
Kro-apps Helm template helpers
gitops/argocd/charts/krm/kro-apps/templates/_helpers.tpl
Added template helper functions for chart naming, namespacing, labeling (standard Helm patterns), and provider-specific labels (k8s, AWS, GCP).
Kro-apps application templates
gitops/argocd/charts/krm/kro-apps/templates/application.yaml, gitops/argocd/charts/krm/kro-apps/templates/kro-application.yaml
Added Kro Run Application CRD template and ResourceGraphDefinition template with conditional AWS S3 and PodIdentity resources.
Kro-apps Helm values
gitops/argocd/charts/krm/kro-apps/values.yaml, gitops/argocd/charts/krm/kro-apps/values-aws-staging.yaml, gitops/argocd/charts/krm/kro-apps/values-talos-homelab.yaml
Added values configuration: version labeling, AWS enablement for staging, and empty document placeholder for homelab.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • Areas requiring extra attention:
    • gitops/argocd/charts/krm/kro-apps/templates/kro-application.yaml — Dense ResourceGraphDefinition spec with conditional resource injection for AWS integration; verify schema fields, template variable interpolation, and conditional branching logic.
    • gitops/argocd/charts/krm/kro-apps/templates/application.yaml — Verify Kro Run API version alignment (kro.run/v1alpha1) and metadata/spec templating consistency.
    • Namespace changes in ApplicationSet values — Confirm these changes align with intended resource placement and don't break existing deployments.

Possibly related PRs

Suggested labels

priority/medium, status/in_progress, kind/feature, area/kubernetes, size/m, lifecycle/active, cloud/homelab, cloud/aws, dependency/argo

Poem

🐰 Charts bloom in the gitops garden today,
Namespaces shuffle from home far away,
Kro-apps now thrive with templates so fine,
AWS integration, a feature divine!
Headers removed, the clutter's at bay ✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/krm-apps

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f7feabc and d2c9459.

📒 Files selected for processing (15)
  • gitops/argocd/apps/krm/values-aws-staging.yaml (1 hunks)
  • gitops/argocd/apps/krm/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/krm/ack/Chart.yaml (0 hunks)
  • gitops/argocd/charts/krm/ack/values-talos-homelab.yaml (0 hunks)
  • gitops/argocd/charts/krm/ack/values.yaml (0 hunks)
  • gitops/argocd/charts/krm/kro-apps/Chart.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/templates/_helpers.tpl (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/templates/application.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/templates/kro-application.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/values-aws-staging.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/values-talos-homelab.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro-apps/values.yaml (1 hunks)
  • gitops/argocd/charts/krm/kro/Chart.yaml (0 hunks)
  • gitops/argocd/charts/krm/kro/values-talos-homelab.yaml (0 hunks)
  • gitops/argocd/charts/krm/kro/values.yaml (0 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nlamirault nlamirault added status/review_needed The issue or PR needs to be reviewed priority/medium This issue or PR may be useful, and needs some attention kind/feature Categorizes issue or PR as related to a new feature area/kubernetes Kubernetes lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Nov 6, 2025
@nlamirault nlamirault merged commit 1a092e2 into master Nov 6, 2025
20 of 21 checks passed
@github-actions github-actions bot added the cloud/aws Cloud Provider / Amazon AWS label Nov 6, 2025
@nlamirault nlamirault deleted the feat/krm-apps branch November 6, 2025 16:24
@github-actions github-actions bot added the size/l Size L label Nov 6, 2025
@dosubot dosubot bot added cloud/homelab Cloud Provider / Homelab dependency/argo Dependency Argo labels Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/kubernetes Kubernetes cloud/aws Cloud Provider / Amazon AWS cloud/homelab Cloud Provider / Homelab dependency/argo Dependency Argo kind/feature Categorizes issue or PR as related to a new feature lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/medium This issue or PR may be useful, and needs some attention size/l Size L status/review_needed The issue or PR needs to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants