-
Notifications
You must be signed in to change notification settings - Fork 6
Some cleanup #6901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Some cleanup #6901
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -4,17 +4,16 @@ about: Suggest an idea for this project | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| title: '' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| labels: '' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| assignees: '' | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| --- | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Is your feature request related to a problem? Please describe.** | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Is your feature request related to a problem? Please describe.** A clear and | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| concise description of what the problem is. Ex. I'm always frustrated when [...] | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Describe the solution you'd like** | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| A clear and concise description of what you want to happen. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Describe the solution you'd like** A clear and concise description of what you | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| want to happen. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Describe alternatives you've considered** | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| A clear and concise description of any alternative solutions or features you've considered. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Describe alternatives you've considered** A clear and concise description of | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| any alternative solutions or features you've considered. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Additional context** | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Add any other context or screenshots about the feature request here. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| **Additional context** Add any other context or screenshots about the feature | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| request here. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+9
to
+19
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the bug report template, removing the blank lines here reduces the readability of the raw markdown. Re-adding them would improve maintainability.
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,7 @@ | |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
|
|
@@ -15,15 +15,15 @@ | |
| FROM alpine:3.19 | ||
|
|
||
| LABEL maintainer="Nicolas Lamirault <[email protected]>" \ | ||
| org.opencontainers.image.title="Tools for Portefaix project" \ | ||
| org.opencontainers.image.description="Tools from the Kubernetes ecosystem" \ | ||
| org.opencontainers.image.authors="Nicolas Lamirault <[email protected]>" \ | ||
| org.opencontainers.image.vendor="Portefaix" \ | ||
| org.opencontainers.image.documentation="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.licenses="Apache 2.0" \ | ||
| org.opencontainers.image.url="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.source="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.version="0.1.0" | ||
| org.opencontainers.image.title="Tools for Portefaix project" \ | ||
| org.opencontainers.image.description="Tools from the Kubernetes ecosystem" \ | ||
| org.opencontainers.image.authors="Nicolas Lamirault <[email protected]>" \ | ||
| org.opencontainers.image.vendor="Portefaix" \ | ||
| org.opencontainers.image.documentation="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.licenses="Apache 2.0" \ | ||
| org.opencontainers.image.url="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.source="https://github.com/portefaix/portefaix" \ | ||
| org.opencontainers.image.version="0.1.0" | ||
|
|
||
| RUN apk add --no-cache ca-certificates curl bash tar jq | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,18 @@ | ||
| # SPDX-FileCopyrightText: Copyright (C) Nicolas Lamirault <[email protected]> | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| --- | ||
| # yaml-language-server: $schema=https://json.schemastore.org/github-workflow.json | ||
| name: OpenTelemetry / Export | ||
|
|
||
| on: | ||
| workflow_run: | ||
| workflows: | ||
| - "Argo / Build" | ||
| - "Flux / Build" | ||
| - "Project / Release Drafter" | ||
| - "Project / Release labels" | ||
| - "Project / Size PR" | ||
| - "Argo / Build" | ||
| - "Flux / Build" | ||
| - "Project / Release Drafter" | ||
| - "Project / Release labels" | ||
| - "Project / Size PR" | ||
|
|
||
| types: [completed] | ||
|
|
||
|
|
@@ -40,17 +43,16 @@ jobs: | |
| # otlpHeaders: ${{ secrets.AXIOM_OTLP_HEADERS }} | ||
| # githubToken: ${{ secrets.GITHUB_TOKEN }} | ||
| # runId: ${{ github.event.workflow_run.id }} | ||
|
|
||
| otel-export-honeycomb: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - name: Export workflow to Honeycomb | ||
| uses: corentinmusard/otel-cicd-action@v2 | ||
| with: | ||
| otlpEndpoint: grpc://api.honeycomb.io:443/ | ||
| # Example value for HONEYCOMB_OTLP_HEADERS: | ||
| # x-honeycomb-team=YOUR_API_KEY,x-honeycomb-dataset=YOUR_DATASET | ||
| otlpHeaders: ${{ secrets.HONEYCOMB_OTLP_HEADERS }} | ||
| githubToken: ${{ secrets.GITHUB_TOKEN }} | ||
| runId: ${{ github.event.workflow_run.id }} | ||
| - uses: actions/checkout@v4 | ||
| - name: Export workflow to Honeycomb | ||
| uses: corentinmusard/otel-cicd-action@v2 | ||
| with: | ||
| otlpEndpoint: grpc://api.honeycomb.io:443/ | ||
| # Example value for HONEYCOMB_OTLP_HEADERS: | ||
| # x-honeycomb-team=YOUR_API_KEY,x-honeycomb-dataset=YOUR_DATASET | ||
| otlpHeaders: ${{ secrets.HONEYCOMB_OTLP_HEADERS }} | ||
| githubToken: ${{ secrets.GITHUB_TOKEN }} | ||
| runId: ${{ github.event.workflow_run.id }} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
.secrets/k3s/homelab/kube-prometheus-stack/alertmanager.yaml
Binary file not shown.
Binary file not shown.
Binary file modified
BIN
-1 Byte
(100%)
.secrets/talos/homelab/kube-prometheus-stack/alertmanager.yaml
Binary file not shown.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While these changes don't affect the rendered output in most markdown viewers, removing the blank lines between sections and between headings and their descriptions reduces the readability of the raw markdown file. It's a good practice to keep these blank lines for better separation and maintainability.