Skip to content

feat: add metric scraping config on web charts #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yosefmih merged 2 commits into from
Dec 13, 2024
Merged

feat: add metric scraping config on web charts #1454

yosefmih merged 2 commits into from
Dec 13, 2024

Conversation

@yosefmih
Copy link
Contributor

@yosefmih yosefmih commented Dec 11, 2024 •
edited
Loading

  • When metric scraping is enabled, add the necessary annotations to the service
  • If metric scraping port is different from the main port, make sure to template that port on the service/pods.

@yosefmih yosefmih requested a review from d-g-town December 13, 2024 15:46
@yosefmih yosefmih merged commit 863c282 into main Dec 13, 2024
2 checks passed
@yosefmih yosefmih deleted the ym/metric_scraping_apps branch December 13, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@d-g-town d-g-town d-g-town approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yosefmih @d-g-town