Improve Cetesdirecto PDF-Importer#5758
Merged
Nirus2000 merged 1 commit intoJun 1, 2026
Merged
Conversation
Member
Nirus2000
commented
Jun 1, 2026
Nirus2000
commented
- Remove dead code (itemsToAddToFront + addAll no-op) from document context initializer
- Rename addDividendeTransaction() to addDividendTransaction() to follow English naming convention
- Remove Javadoc and inline comments from TaxAmountTransactionHelper.findItem() that described what the code does rather than why
- Add missing hasExDate(null) to all four dividend assertions in the test
- Rename test method testWertpapierKauf27 → testEdoCta01 to match the source document name
- Remove dead code (itemsToAddToFront + addAll no-op) from document context initializer - Rename addDividendeTransaction() to addDividendTransaction() to follow English naming convention - Remove Javadoc and inline comments from TaxAmountTransactionHelper.findItem() that described what the code does rather than why - Add missing hasExDate(null) to all four dividend assertions in the test - Rename test method testWertpapierKauf27 → testEdoCta01 to match the source document name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.