Improve ComDirect PDF-Importer#5759
Merged
Nirus2000 merged 1 commit intoJun 1, 2026
Merged
Conversation
Member
Nirus2000
commented
Jun 1, 2026
Nirus2000
commented
- Rename addDividendeTransaction() to addDividendTransaction() to follow English naming convention
- Normalize currency values with asCurrencyCode() when storing into document context (currency and foreignCurrency keys in addFinancialReport())
- Add missing hasExDate(null) to all 127 dividend assertions in the test and add the corresponding import
- Fix three hasTaxes("EUR", 0.0) → 0.00 to use double literal for zero amounts
- Rewrite testFinanzreport13 to use Hamcrest matchers instead of assertTrue/assertEquals, remove WHAT-comments, add missing results.size() assertion, and remove the now-unused org.junit.Assert imports
- Rename addDividendeTransaction() to addDividendTransaction() to follow English naming convention
- Normalize currency values with asCurrencyCode() when storing into document context (currency and foreignCurrency keys in addFinancialReport())
- Add missing hasExDate(null) to all 127 dividend assertions in the test and add the corresponding import
- Fix three hasTaxes("EUR", 0.0) → 0.00 to use double literal for zero amounts
- Rewrite testFinanzreport13 to use Hamcrest matchers instead of assertTrue/assertEquals, remove WHAT-comments, add missing results.size() assertion, and remove the now-unused org.junit.Assert imports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.