-
Notifications
You must be signed in to change notification settings - Fork 30
V1 REST API 문서에서 누락된 description들이 정상적으로 보여지도록 수정 #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @SonnySon17, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 V1 REST API 문서에서 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
V1 REST API 문서에서 x-portone-description 프로퍼티가 올바르게 표시되지 않던 문제를 해결하기 위한 변경 사항을 확인했습니다. scripts/download-schema.ts 파일에서 x-portone-description 프로퍼티에 대해 GFM 렌더링을 건너뛰도록 조건을 추가하여, 프론트엔드에서 마크다운으로 정상 처리될 수 있도록 수정한 점이 좋습니다. 변경된 코드는 명확하며, 설명된 문제를 정확히 해결합니다. 좋은 수정입니다.
|



요약
V1 REST API 문서에서
x-portone-description이 표시되지 않던 문제를 해결했습니다.문제
x-portone-name과x-portone-description필드가 정의되어 있음x-portone-name은 표시되지만x-portone-description은 표시되지 않음x-portone-description을 HTML로 변환했는데, 프론트엔드에서 마크다운 파서로 처리하려고 해서 렌더링 실패해결 방법
1. 스키마 다운로드 로직 수정
scripts/download-schema.ts에서x-portone-description을 HTML로 변환하지 않고 원본 텍스트 그대로 유지2. 스키마 파일 업데이트
x-portone-description이 이제 일반 텍스트 형식으로 저장됨테스트
x-portone-description정상 표시 확인As-Is
To-Be