-
Notifications
You must be signed in to change notification settings - Fork 30
feat: 갤럭시아 v2 문서 추가, 지원 결제 수단에 머니트리 추가 #996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Summary of ChangesHello @youjmen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 갤럭시아 결제 게이트웨이의 v2 버전에 대한 포괄적인 문서를 도입하여 개발자들이 새로운 버전의 기능을 쉽게 통합할 수 있도록 합니다. 또한, 기존 v1 문서에 머니트리 간편 결제 옵션을 추가하여 사용자에게 더 넓은 결제 선택권을 제공합니다. 전반적으로 결제 시스템의 문서화와 기능적 유연성을 향상시키는 데 중점을 둡니다. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
안녕하세요. 갤럭시아 v2 연동 문서 추가 및 v1 문서 업데이트에 대한 리뷰입니다.
새로운 v2 문서가 상세하게 잘 작성되었습니다. 다만, 문서의 정확성과 일관성을 높이기 위해 몇 가지 수정이 필요해 보입니다. 예제 코드의 파라미터 값 오류, 파라미터 설명의 불일치, 그리고 지원 결제 수단 목록 누락 등의 문제를 발견했습니다. 자세한 내용은 각 파일에 대한 개별 코멘트를 참고해주세요.
| paymentId: `payment${crypto.randomUUID()}`, | ||
| orderName: "나이키 와플 트레이너 2 SD", | ||
| totalAmount: 1000, | ||
| currency: "CURRENCY_KRW", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youjmen 저희 prefix 없애는걸 기본으로 하고 있어서 그냥 KRW 로 해야 할 것 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제거했습니다~
| paymentId: `payment${crypto.randomUUID()}`, | ||
| orderName: "나이키 와플 트레이너 2 SD", | ||
| totalAmount: 1000, | ||
| currency: "CURRENCY_KRW", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@youjmen 저희 prefix 없애는걸 기본으로 하고 있어서 그냥 KRW 로 해야 할 것 같아요
|



No description provided.