PWX-50095 | Fix nil labels issue for helm4#867
Open
hitesh-wani-px wants to merge 1 commit intopre-release-portworx-8.2.0from
Open
PWX-50095 | Fix nil labels issue for helm4#867hitesh-wani-px wants to merge 1 commit intopre-release-portworx-8.2.0from
hitesh-wani-px wants to merge 1 commit intopre-release-portworx-8.2.0from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Helm 4 introduced stricter template rendering behavior compared to Helm 3.
The existing logic was rendering the labels block unconditionally, which caused template rendering failures in Helm 4 when no labels were present.
This PR updates the template to conditionally render the labels section only when labels exist ($hasLabels). This ensures compatibility with Helm 4 while preserving existing Helm 3 behavior
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
portworx-apiserive