Skip to content

Conversation

@stschiff
Copy link
Member

No description provided.

@nevrome
Copy link
Member

nevrome commented Aug 21, 2025

Decisions for .janno column changes:

  1. ReferenceGenome in Capture_Type: Read into legacy constructor with make, warn about it with inspect, return NA with show.
  2. Endogenous+Damage: No change in parser, manual post-processing in readJannoFileRow: rescale by factor 100 in case of version < 3.0.0.

@nevrome
Copy link
Member

nevrome commented Aug 21, 2025

For unix line endings: Packages should be checked for that and a warning thrown (one per package). They should be read anyway, though.

@stschiff
Copy link
Member Author

Rough division of labour:

  • Stephan: Changes in YAML and Poseidon_ID + Xerxes mono repo merge
  • Clemens. Changes in Janno and SSF

@stschiff stschiff changed the title first API changes Version 3.0.0 changes Nov 3, 2025
@nevrome
Copy link
Member

nevrome commented Dec 1, 2025

Meeting 2025/12/01: Clemens will revert 05a23a1 and merge #357 when reviewed.

@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.83%. Comparing base (78cc88b) to head (8865d3d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   56.83%   56.83%           
=======================================
  Files          33       33           
  Lines        4993     4993           
  Branches      546      546           
=======================================
  Hits         2838     2838           
  Misses       1609     1609           
  Partials      546      546           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nevrome
Copy link
Member

nevrome commented Dec 15, 2025

I finally went ahead and reverted 05a23a1 to turn this PR to a clean slate for all Poseidon v3.0.0-related changes. I also redirected #357 to be merged into this branch. So I think the next steps should be as follows:

  1. Stephan finishes Server retired packages #356 and Clemens finishes Changes to .janno and .ssf columns for Poseidon v3.0.0 #357 with reciprocal review.
  2. Changes to .janno and .ssf columns for Poseidon v3.0.0 #357 gets merged into Version 3.0.0 changes #351 here.
  3. Stephan branches of from here and implements the changes documented above as Changes in YAML and Poseidon_ID + Xerxes mono repo merge. He delegates tasks as he deems useful.

@stschiff
Copy link
Member Author

stschiff commented Jan 6, 2026

OK, I finished #356 and will now start with the YAML and Poseidon_ID changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants