Yaml changes v3 #363
Open
Yaml changes v3 #363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## Schema_300_dev #363 +/- ##
==================================================
+ Coverage 56.83% 56.89% +0.05%
==================================================
Files 33 33
Lines 4993 5043 +50
Branches 546 548 +2
==================================================
+ Hits 2838 2869 +31
- Misses 1609 1626 +17
- Partials 546 548 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
nevrome
approved these changes
Jan 8, 2026
| instance FromJSON LicenseSpec where | ||
| parseJSON = withObject "LicenseSpec" $ \v -> LicenseSpec | ||
| <$> v .: "name" | ||
| <*> v .: "url" |
Member
There was a problem hiding this comment.
Above you define licenseURL :: Maybe String, but here you use v .: "url". I'm surprised this even compiles. Should be .:?, right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added the license file fields and the additional reference assembly fields for genotype data to the Yaml file structure.