Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10 +/- ##
=======================================
Coverage 44.49% 44.49%
=======================================
Files 5 5
Lines 227 227
Branches 18 18
=======================================
Hits 101 101
Misses 108 108
Partials 18 18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
To keep you in the loop, @stschiff, qjanno should be prepared now. |
stschiff
approved these changes
Mar 18, 2026
Member
stschiff
left a comment
There was a problem hiding this comment.
Nice. I didn't go into all glorious depth, but great to keep this updated as well. I noticed a bit code-duplication with poseidon-hs (two comments)... not sure whether we can easily pull in poseidon-hs into this code-base?
Member
Author
|
I think this little duplication is fine. Pulling in the poseidon-hs behemoth as a dependency here just for one function would be overkill, imho. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: Add column sorting for
_Notecolumns as in trident.Edit: Done.