Skip to content

Maintenance for Poseidon v3.0.0#10

Merged
nevrome merged 8 commits intomainfrom
v300
Mar 23, 2026
Merged

Maintenance for Poseidon v3.0.0#10
nevrome merged 8 commits intomainfrom
v300

Conversation

@nevrome
Copy link
Copy Markdown
Member

@nevrome nevrome commented Mar 17, 2026

TODO: Add column sorting for _Note columns as in trident.
Edit: Done.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.49%. Comparing base (25d368a) to head (d5815f1).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #10   +/-   ##
=======================================
  Coverage   44.49%   44.49%           
=======================================
  Files           5        5           
  Lines         227      227           
  Branches       18       18           
=======================================
  Hits          101      101           
  Misses        108      108           
  Partials       18       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nevrome nevrome marked this pull request as ready for review March 18, 2026 06:14
@nevrome
Copy link
Copy Markdown
Member Author

nevrome commented Mar 18, 2026

To keep you in the loop, @stschiff, qjanno should be prepared now.

Copy link
Copy Markdown
Member

@stschiff stschiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I didn't go into all glorious depth, but great to keep this updated as well. I noticed a bit code-duplication with poseidon-hs (two comments)... not sure whether we can easily pull in poseidon-hs into this code-base?

Comment thread src/Qjanno/Janno.hs
Comment thread src/Qjanno/Janno.hs
@nevrome
Copy link
Copy Markdown
Member Author

nevrome commented Mar 18, 2026

I think this little duplication is fine. Pulling in the poseidon-hs behemoth as a dependency here just for one function would be overkill, imho.

@nevrome nevrome merged commit 1ca9480 into main Mar 23, 2026
4 checks passed
@nevrome nevrome deleted the v300 branch March 23, 2026 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants