Repository navigation
fix(mcp): Allow several tool groups in btw_mcp_server() - #221
Merged
Merged
Conversation
The R file detection chained `is.character(tools) && file.exists(tools)`, which errors under R >= 4.3 when `tools` names more than one tool group. Use `is_string()` so the file branch only considers a single path. Fixes posit-dev#206
taekop
force-pushed
the
fix/mcp-server-multiple-tools
branch
from
September 25, 2026 15:59
e294d1e to
76c7dec
Compare
…e `tools` argument passed to mcptools::mcp_server() and check that a character vector of tool groups is flattened to tools from those groups, and that a path to an .R script is passed through unflattened. Follows up on posit-dev#206, PR posit-dev#221.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #206
Summary
btw_mcp_server()checks whethertoolsis a path to an R file withis.character(tools) && file.exists(tools) && .... Whentoolsnames more than one tool group, e.g.btw_mcp_server(c("docs", "env", "sessioninfo")),file.exists()returns a vector and&&errors under R >= 4.3, so the server fails on startup. This swapsis.character()foris_string(), so the file branch only applies to a single path.Verification
The new test in
test-mcp.Rcallsbtw_mcp_server(tools = c("docs", "env"))withmcptools::mcp_server()mocked. It errors onmainwith'length = 2' in coercion to 'logical(1)'and passes with this change.