Skip to content

fix: have preview() work with duration columns #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rich-iannone merged 3 commits into from
Feb 21, 2026
Merged

fix: have preview() work with duration columns #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9da57c
Cast duration dtypes for display table
rich-iannone Feb 20, 2026
0f59bc3
Update schema.py
rich-iannone Feb 20, 2026
053a5d1
Update field.py
rich-iannone Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pointblank/field.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1941,7 +1941,7 @@ def duration_field(
),
)

pb.generate_dataset(schema, n=100, seed=23)
pb.preview(pb.generate_dataset(schema, n=100, seed=23))
```

Colon-separated strings can also be used for quick duration definitions:
Expand All @@ -1952,7 +1952,7 @@ def duration_field(
break_time=pb.duration_field(min_duration="0:05:00", max_duration="0:30:00"),
)

pb.generate_dataset(schema, n=30, seed=23)
pb.preview(pb.generate_dataset(schema, n=30, seed=23))
```

Optional durations can be created with `nullable=True`, and duration fields work well
Expand All @@ -1972,7 +1972,7 @@ def duration_field(
),
)

pb.generate_dataset(schema, n=30, seed=7)
pb.preview(pb.generate_dataset(schema, n=30, seed=7))
```
"""
return DurationField(
Expand Down
2 changes: 1 addition & 1 deletion pointblank/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1821,7 +1821,7 @@ def test_age_range(generate_dataset):
),
)

pb.generate_dataset(schema, n=50, seed=23)
pb.preview(pb.generate_dataset(schema, n=50, seed=23))
```
"""
return schema.generate(
Expand Down
22 changes: 22 additions & 0 deletions pointblank/validate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@
_format_to_integer_value,
_get_fn_name,
_get_tbl_type,
_is_duration_dtype,
_is_lazy_frame,
_is_lib_present,
_is_narwhals_table,
Expand Down Expand Up @@ -2442,6 +2443,27 @@ def _generate_display_table(

none_values = [(k, i) for k, v in none_values.items() for i, val in enumerate(v) if val]

# Cast duration columns to string for display since Great Tables cannot handle duration types;
# the original dtype labels are already captured in `col_dtype_dict` / `col_dtype_dict_short`
# so they will still show correctly in the column headers
duration_cols = [
col_name
for col_name, col_dtype in col_dtype_dict.items()
if _is_duration_dtype(col_dtype.lower())
]
if duration_cols:
if df_lib_name_gt == "polars":
import polars as pl

for c in duration_cols:
vals = data[c].to_list()
str_vals = [str(v) if v is not None else None for v in vals]
data = data.with_columns(pl.Series(c, str_vals, dtype=pl.Utf8))
else:
# Pandas (and PySpark converted to Pandas)
for c in duration_cols:
data[c] = data[c].astype(str)

# Import Great Tables to get preliminary renders of the columns
import great_tables as gt

Expand Down
Loading