Merged
Conversation
We switch from `credentialless` to `require-corp` for the COEP header when the shinylive service worker is adding COI headers. This fixes both `browser()` and CURL on webR when running under Shiny.
wch
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changes to the service worker only apply when the
?coi=1query parameter is used with Shinylive. This is an undocumented (IIRC) feature required for usingbrowser()(and now also CURL) in webR on Safari. The feature is disabled by default, and not many users are relying on it, so it should be fairly safe to tweak.