Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): clone parameter should be optional #275

Closed
wants to merge 1 commit into from

Conversation

btea
Copy link
Contributor

@btea btea commented Apr 28, 2023

No description provided.

@btea
Copy link
Contributor Author

btea commented Apr 28, 2023

@alexander-akait Can you review this pr? Thanks!

@btea
Copy link
Contributor Author

btea commented Apr 28, 2023

It looks like the reason for the test failing seems to be a timeout 🤔

@alexander-akait
Copy link
Collaborator

Can you investigate it? Sorry I don't have time on it, only merge and do release 😞

@btea
Copy link
Contributor Author

btea commented Apr 28, 2023

ok, I'll look into it later. Thank you so much for taking the time to review this. ❤️

@btea
Copy link
Contributor Author

btea commented Apr 28, 2023

According to the failure, it seems to be related to the node version. However, I installed the corresponding version (14) and then ran the test and everything seemed to be fine, and no valid information was obtained.😞

It may be related to the system. My machine is win11, and ci seems to be ubuntu. Maybe I should configure the relevant environment tomorrow and check again.

@alexander-akait
Copy link
Collaborator

Let's try to update test runner, maybe just a bug?

@btea
Copy link
Contributor Author

btea commented Apr 28, 2023

What should I do?

@alexander-akait
Copy link
Collaborator

Try to update dev deps

@btea
Copy link
Contributor Author

btea commented Apr 29, 2023

Run npm update -D to update all dependencies? After I ran the test after the update, a similar error message appeared, but I still can't figure out where the problem is.

@alexander-akait
Copy link
Collaborator

Fixed #276 release will be soon

@btea
Copy link
Contributor Author

btea commented Apr 29, 2023

ok, thank you for your hard work! I found that you deleted the package-lock.json file, so the previous test failure has something to do with this file?

@btea btea deleted the type/clone-params branch April 29, 2023 13:45
@alexander-akait
Copy link
Collaborator

alexander-akait commented Apr 29, 2023

I don't delete it, just regenerate for v1, becaue v1 and v2 are incompatibility (don't know why npm command done this bad breaking change, and I think such things should never happen with package managers)

@btea
Copy link
Contributor Author

btea commented Apr 29, 2023

ok, I see, thanks for your reply ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants