-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(types): clone parameter should be optional #275
Conversation
@alexander-akait Can you review this pr? Thanks! |
It looks like the reason for the test failing seems to be a timeout 🤔 |
Can you investigate it? Sorry I don't have time on it, only merge and do release 😞 |
ok, I'll look into it later. Thank you so much for taking the time to review this. ❤️ |
According to the failure, it seems to be related to the node version. However, I installed the corresponding version (14) and then ran the test and everything seemed to be fine, and no valid information was obtained.😞 It may be related to the system. My machine is win11, and ci seems to be ubuntu. Maybe I should configure the relevant environment tomorrow and check again. |
Let's try to update test runner, maybe just a bug? |
What should I do? |
Try to update dev deps |
Run |
Fixed #276 release will be soon |
ok, thank you for your hard work! I found that you deleted the package-lock.json file, so the previous test failure has something to do with this file? |
I don't delete it, just regenerate for v1, becaue v1 and v2 are incompatibility (don't know why npm command done this bad breaking change, and I think such things should never happen with package managers) |
ok, I see, thanks for your reply ❤️ |
No description provided.