Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test on Node.js 22 #301

Merged
merged 7 commits into from
Feb 10, 2025
Merged

Conversation

btea
Copy link
Contributor

@btea btea commented Jan 5, 2025

https://github.com/nodejs/node/releases/tag/v22.0.0
Node.js version 22 has been released, we can add this to the system environment where the tests are run.

@alexander-akait
Copy link
Collaborator

Looks like tests are broken

@btea
Copy link
Contributor Author

btea commented Feb 5, 2025

It looks like node22 doesn't support commonjs. 🤔

@btea
Copy link
Contributor Author

btea commented Feb 8, 2025

The previous error seemed to be because the --experimental-detect-module flag was enabled by default in node22.7.0, causing module detection to fail. https://github.com/nodejs/node/releases/tag/v22.7.0

Currently to prevent tests from failing on node22 I add the --no-experimental-detect-module flag when running the tests.

@alexander-akait
Copy link
Collaborator

Thanks

@alexander-akait alexander-akait merged commit 6343f29 into postcss:master Feb 10, 2025
5 checks passed
@btea btea deleted the ci/test-on-node22 branch February 10, 2025 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants