Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add arm64 go builds and docker images #184

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Conversation

fmarani
Copy link
Contributor

@fmarani fmarani commented Jan 9, 2025

Hopefully this PR should be enough to get the project deployable on arm64 machines.

These are the action results on my fork (see here):
image

I have not tested the release workflows as they required a bit more work. I am trusting the docker_manifest section works as is.

@clementnuss clementnuss self-requested a review January 22, 2025 06:21
@clementnuss clementnuss self-assigned this Jan 22, 2025
@gueux
Copy link

gueux commented Feb 11, 2025

Its very useful for Amazon EKS Auto mode, that support ARM64 nodes via built-in System Node Pool.
@clementnuss Are there any plans to merge this into main?

@clementnuss clementnuss merged commit 0d5b56a into postfinance:main Feb 12, 2025
5 checks passed
@clementnuss
Copy link
Contributor

clementnuss commented Feb 12, 2025

this looks good, thanks a lot the the PR @fmarani and the reminder @gueux

@clementnuss
Copy link
Contributor

image

perfect !

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13286620675

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 62.259%

Totals Coverage Status
Change from base Build 12902896356: 0.0%
Covered Lines: 452
Relevant Lines: 726

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants