Conversation
added 8 commits
March 15, 2016 18:50
Establish precedence between authentication methods Update Readme Add tests for rc configuration
Tests for RC
Reason: You need to install the module you are currently working on.
| npm install npm-cli-login | ||
|
|
||
| Use -g flag to use npm-cli-login via the CLI | ||
| Using the -g flag isn't necessary when you run via NPM |
Contributor
There was a problem hiding this comment.
Most people use it as the CLI, so let's keep the example with -g.
| }, function (err, data) { | ||
| if (err) { | ||
| return callback(err); | ||
| throw new Error(err); |
Contributor
There was a problem hiding this comment.
Why throw instead of passing to the callback?
Contributor
Author
There was a problem hiding this comment.
Just a precaution to make sure never ever do I write to NPMRC unless absolutely sure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.