Fix noDefaults not being respected by v21 to v1 converter#663
Merged
ekansh-001 merged 2 commits intodevelopfrom May 30, 2025
Merged
Fix noDefaults not being respected by v21 to v1 converter#663ekansh-001 merged 2 commits intodevelopfrom
ekansh-001 merged 2 commits intodevelopfrom
Conversation
kartikjain26
approved these changes
May 29, 2025
codenirvana
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Even after passing noDefaults to the transformer, v21 to v1 was not respecting the parameter, as it was getting sanitized due to handpicked options being passed to builders.