Get address fields by dataScope instead of name#255
Open
woutk88 wants to merge 2 commits intopostnl:masterfrom
Open
Get address fields by dataScope instead of name#255woutk88 wants to merge 2 commits intopostnl:masterfrom
woutk88 wants to merge 2 commits intopostnl:masterfrom
Conversation
…are still found when they are moved from the default posiiton.
Contributor
|
Hey @woutk88 , Thank you for submitting this, we will look at the pull request and place it on our backlog to add to the extension. Have a great day, |
|
Any updates on this? It has been a while since this PR was send-in for review. |
|
Any news on this pull request? |
Contributor
|
Hi, Thank you for contacting us, I'm going to find out the status of this pull request and will come back with an update soon! Have a great day, |
Contributor
|
Hi, Like I promised, an update on this request. We couldn't get the pull request working on a clean environment. But it is still on our backlog to find a fix for this, we already tried some ideas but haven't found the right solution yet. Have a great day, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After updating to version 1.9.7 or higher, timeframes and locations aren't loading anymore for guest customers, because we've moved (re-ordered and re-grouped) address fields in the checkout (for multiple clients). Turns out this is happening because from version 1.9.7 the address fields are retrieved by name. These names are very specific and will change when a field is moved. The dataScope however should stay the same, therefore it would be more reliable and flexible to use this to get the fields.