-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add children route names generic to generated RouteNamedMap
and adjust docs and tests
#602
base: main
Are you sure you want to change the base?
feat: add children route names generic to generated RouteNamedMap
and adjust docs and tests
#602
Conversation
…nd adjust docs and tests
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/[email protected], npm/[email protected], npm/[email protected] |
commit: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #602 +/- ##
==========================================
+ Coverage 61.72% 61.80% +0.08%
==========================================
Files 32 32
Lines 3135 3142 +7
Branches 580 583 +3
==========================================
+ Hits 1935 1942 +7
Misses 1194 1194
Partials 6 6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some extra info 😄
@@ -198,5 +199,17 @@ | |||
"vuefire": "^3.2.1", | |||
"webpack": "^5.97.1", | |||
"yorkie": "^2.0.0" | |||
}, | |||
"pnpm": { | |||
"onlyBuiltDependencies": [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this should be in this PR. With pnpm v10, builds have to be approved. After you do, pnpm adds "approved builds" to package.json
.
"vue-demi", | ||
"yorkie" | ||
], | ||
"patchedDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This temporary patch needs to be removed before merging.
@@ -0,0 +1,73 @@ | |||
diff --git a/dist/vue-router.d.ts b/dist/vue-router.d.ts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This temporary patch needs to be removed before merging.
Description
Note
This PR is intended to be paired with the following
vue-router
PR: vuejs/router#2475.This PR itself contains a temporary
pnpm
patch file that applies the changes in above-mentioned PR to work on this feature and make sure you can run tests and generate docs properly. Before merging, this patch needs to be removed andvue-router
should be updated if thevue-router
PR is merged.This extends generated

RouteRecordInfo
objects inRouteNamedMap
to make sure every route defines the route names of their children routes. NowuseRoute('/parent')
can return the typings of both the parent route and its children routes, as can be seen in the example in the adjusted docs: