feat: allow filePath
to be null
on a route added in an editable tree
#607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that, when we only allow
filePath
to benull
on a route added in an editable tree, that shouldn't cause any problems.In Nuxt, we don't use file scanning and add routes by modifying the
EditableTreeNode
of the root page in thebeforeWriteFiles
callback. ANuxtPage
can theoretically not have a correspondingfile
, although I'm not sure what the use case here is exactly. So currently, where we runparent.insert(path, page.file)
,page.file
can beundefined
and we currently use a@ts-expect-error
before that line to suppress TS errors.If this PR is safe to merge, we can remove that
@ts-expect-error
.