Fix translate window shrinking on Windows with mixed DPI monitors#1257
Open
wyl2003 wants to merge 1 commit into
Open
Fix translate window shrinking on Windows with mixed DPI monitors#1257wyl2003 wants to merge 1 commit into
wyl2003 wants to merge 1 commit into
Conversation
Updated window size setting to use logical size instead of physical size.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix an issue where the translation window (selection translate) becomes smaller after each translation when "Remember window size" is enabled on Windows, especially with mixed-DPI multi-monitor setups (e.g. 150% + 100%).
Why
translate_window_width/heightare persisted from the frontend as logical sizes (converted fromouterSize()viatoLogical(scaleFactor)), but the Rust window creation code restored them as physical sizes by multiplying bymonitor.scale_factor()again. This unit mismatch causes size drift across resizes/opens.How
Restore the translate window using logical units:
tauri::LogicalSizeforset_sizedpiscaling on restore