Skip to content

Show only audio files #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
merongivian wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Show only audio files #15

merongivian wants to merge 1 commit into from

Conversation

@merongivian
Copy link

@merongivian merongivian commented Jun 5, 2016

No description provided.

@potomak
Copy link
Owner

potomak commented Jun 5, 2016 •
edited
Loading

Thanks for this patch, it looks great!

I have two comments:

  1. I think afplay supports more formats so it could be useful to add more allowed extensions to the list, see https://developer.apple.com/library/ios/documentation/MusicAudio/Conceptual/CoreAudioOverview/SupportedAudioFormatsMacOSX/SupportedAudioFormatsMacOSX.html for more info
  2. what would you think of down casing file extensions before matching them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@merongivian @potomak