Add the live option to allowed params#72
Open
andrewosh wants to merge 1 commit intopouchdb-community:masterfrom
Open
Add the live option to allowed params#72andrewosh wants to merge 1 commit intopouchdb-community:masterfrom
live option to allowed params#72andrewosh wants to merge 1 commit intopouchdb-community:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the module -- it's proven really useful in my application! I was wondering: is there any reason that
liveis excluded fromALLOWED_PARAMS? In my testing,db.syncbehavior can be replicated nicely by adding this option and callingdump/loadfrom a set of input/output streams once, when the DB is first created.Any complexities I'm overlooking here that could lead to future errors? If not, then this might be a useful change for others. Thanks again!