Only return invalid user id when it's the only error#171
Draft
danschultzer wants to merge 1 commit intomainfrom
Draft
Only return invalid user id when it's the only error#171danschultzer wants to merge 1 commit intomainfrom
danschultzer wants to merge 1 commit intomainfrom
Conversation
danschultzer
force-pushed
the
only-return-invalid-user-id-when-only-error
branch
from
982a747 to
99a85d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idea for resolving #170. Not sure about this one as it seems there will be plenty of edge cases to this. The better way of handling this is probably to add a way to more easily manage auth flow. This ties in with my comment in pow-auth/pow#234 (comment) where you have a plug like interface to handle auth flow in one module.