Update tracing for PGO #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schaeff
reviewed
Apr 24, 2025
| @@ -32,7 +32,7 @@ pub trait LocalOpcode { | |||
|
|
|||
| #[repr(C)] | |||
| #[derive(Copy, Clone, Debug, Hash, PartialEq, Eq, derive_new::new, Serialize, Deserialize)] | |||
| pub struct VmOpcode(usize); | |||
leonardoalt
reviewed
Apr 25, 2025
crates/vm/src/arch/segment.rs
Outdated
| let step = self.chip_complex.base.program_chip.program.step; | ||
| let pc = pc_base + (step * (index as u32)); | ||
| tracing::debug!("pc: {pc:#x} | index: {index} | instruction: {instruction:?}"); | ||
| }); |
There was a problem hiding this comment.
Is this for debug only? Can we remove?
crates/vm/src/arch/segment.rs
Outdated
| // tracing::trace!("pc: {pc:#x} | time: {timestamp} | {:?}", instruction); | ||
| // update the trace event for logging instructions in execution order in our profiler via a custom subscriber | ||
| tracing::trace!( | ||
| pc = pc, |
There was a problem hiding this comment.
I think we should have pc only
leonardoalt
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes needed for https://github.com/powdr-labs/powdr-openvm/pull/82/.