Prover functions for small arith. #2608
Conversation
chriseth
requested review from
qwang98 and
georgwiese
and removed request for
qwang98
| int_to_limbs(quotient) + int_to_limbs(remainder) | ||
| } | ||
| } | ||
| ); |
There was a problem hiding this comment.
I have reviewed the mathematics behind all the computation and after a first look, it seems to makes sense (it is even clearer than before). What I don't quite understand is the use of the query function. I understand that the results are assigned in y3 + x1, but when is it “called” for that to happen? Is it related to the div operation defined above, right?
There was a problem hiding this comment.
In the runtime solver, (all) query functions are executed when there is no more progress, I think. It works because eval silently fails if the value is not there yet. If all eval calls succeed, then the computed value is assigned to the target columns.
Co-authored-by: Georg Wiese <[email protected]>
…-labs/powdr into use_queue_for_identity_queue
…to enable_permutations
…to enable_permutations
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: e581da7 | Previous: d5b42f4 | Ratio |
|---|---|---|---|
jit-witgen-benchmark/jit_witgen_benchmark |
10269002678 ns/iter (± 54321890) |
8159943222 ns/iter (± 81282688) |
1.26 |
executor-benchmark/keccak |
21383799391 ns/iter (± 593035323) |
17378422559 ns/iter (± 83429354) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
|
@chriseth I'm guessing we do want this soon? |
Tests working for "small":
Not working: