Prover functions for small arith. #2608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriseth
requested review from
qwang98 and
georgwiese
and removed request for
qwang98
gzanitti
reviewed
Mar 28, 2025
| int_to_limbs(quotient) + int_to_limbs(remainder) | ||
| } | ||
| } | ||
| ); |
There was a problem hiding this comment.
I have reviewed the mathematics behind all the computation and after a first look, it seems to makes sense (it is even clearer than before). What I don't quite understand is the use of the query function. I understand that the results are assigned in y3 + x1, but when is it “called” for that to happen? Is it related to the div operation defined above, right?
There was a problem hiding this comment.
In the runtime solver, (all) query functions are executed when there is no more progress, I think. It works because eval silently fails if the value is not there yet. If all eval calls succeed, then the computed value is assigned to the target columns.
Co-authored-by: Georg Wiese <[email protected]>
…-labs/powdr into use_queue_for_identity_queue
…to enable_permutations
…to enable_permutations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.