Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session builder: create pipeline from ELF files #2620

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

gballet
Copy link
Collaborator

@gballet gballet commented Apr 1, 2025

Add a pipeline_from_elf method to the session builder, in order to be capable of creating sessions from a non-rust ELF riscv32imc file.

The proposed change is to still use guest_path as an input function, and change the behavior based on what item is pointed at by the path:

  • if the path is a directory, it will try to compile it as a rust project
  • if the path is a file, it will try to interpret it as a riscv ELF file

@gballet gballet marked this pull request as draft April 1, 2025 12:04
@gballet gballet force-pushed the add-pipeline-from-elf branch from 9b99107 to 67dfea5 Compare April 1, 2025 12:39
@gballet gballet force-pushed the add-pipeline-from-elf branch from 67dfea5 to 80fcfe7 Compare April 1, 2025 12:49
@gballet
Copy link
Collaborator Author

gballet commented Apr 1, 2025

Tested and it worked (well, it failed on #2622, which means it loaded the file)

@gballet gballet marked this pull request as ready for review April 1, 2025 20:13
@gballet gballet mentioned this pull request Apr 1, 2025
5 tasks
@leonardoalt leonardoalt added this pull request to the merge queue Apr 3, 2025
Merged via the queue into powdr-labs:main with commit 041ef4e Apr 3, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants