fix(number/goldilocks): enforce canonicalization in from_str_radix #3470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardoalt
reviewed
Jan 12, 2026
| Ok(Self::from_canonical_u64(n)) | ||
| } else { | ||
| Err(format!("Number \"{s}\" too large for Goldilocks field.")) | ||
| } |
Member
There was a problem hiding this comment.
This changes the semantics of this function. Currently, the stored value is not greater than ORDER, as From<u64>calls wrap(n), so I assume that's the desired behavior for now. @chriseth wdyt?
Member
There was a problem hiding this comment.
This function is completely undocumented, which is an fault on our part.
But I think the function is only used in tests, so this is probably a good change.
Member
|
Closed and re-opened to trigger CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GoldilocksField::from_str_radix constructed with Self(n) and could store values ≥ ORDER, violating the invariant that values are always canonical. This led to potential incorrect behavior in arithmetic and formatting. The function now rejects values ≥ ORDER and constructs via from_canonical_u64. Added tests to assert rejection of ORDER and acceptance of ORDER−1 to lock in the behavior.